Skip to content

[Bug][Subscription Billing] Refactor Contract Line Page Loading Logic to Prevent corrupting Subscription Line#6925

Merged
djukicmilica merged 2 commits intomicrosoft:mainfrom
miljance:SBRefactorContractLinePageLoadingLogic
Mar 26, 2026
Merged

[Bug][Subscription Billing] Refactor Contract Line Page Loading Logic to Prevent corrupting Subscription Line#6925
djukicmilica merged 2 commits intomicrosoft:mainfrom
miljance:SBRefactorContractLinePageLoadingLogic

Conversation

@miljance
Copy link
Copy Markdown
Contributor

@miljance miljance commented Mar 2, 2026

Summary

This pull request refactors several pages in the Subscription Billing app to remove redundant initialization procedures and streamline how service commitment and service object records are loaded. The changes improve code consistency, reduce duplication, and enhance maintainability. Additionally, minor logic improvements were made to ensure correct handling of temporary tables and comment lines.

Work Item(s)

Fixes #6280

Fixes AB#625943

…ption, billing base period misuse on comment lines, and stale timestamp errors
@miljance miljance requested a review from a team as a code owner March 2, 2026 16:00
@github-actions github-actions bot added AL: Apps (W1) Add-on apps for W1 From Fork Pull request is coming from a fork labels Mar 2, 2026
@JesperSchulz JesperSchulz added the Finance GitHub request for Finance area label Mar 5, 2026
@JesperSchulz JesperSchulz added the Linked Issue is linked to a Azure Boards work item label Mar 18, 2026
@github-actions github-actions bot added this to the Version 29.0 milestone Mar 18, 2026
@JesperSchulz JesperSchulz enabled auto-merge (squash) March 19, 2026 14:27
auto-merge was automatically disabled March 19, 2026 14:39

Pull request was closed

@JesperSchulz
Copy link
Copy Markdown
Contributor

Re-triggering CI.

@JesperSchulz JesperSchulz reopened this Mar 19, 2026
@JesperSchulz JesperSchulz enabled auto-merge (squash) March 19, 2026 14:40
auto-merge was automatically disabled March 20, 2026 09:34

Pull request was closed

@djukicmilica djukicmilica reopened this Mar 20, 2026
@djukicmilica djukicmilica enabled auto-merge (squash) March 20, 2026 09:34
@miljance
Copy link
Copy Markdown
Contributor Author

@JesperSchulz and @djukicmilica the test should no longer fail. The test was introduced on 18.3.2026 and then disabled on 20.3.2026.

image

auto-merge was automatically disabled March 23, 2026 16:16

Pull request was closed

@djukicmilica djukicmilica reopened this Mar 23, 2026
@djukicmilica djukicmilica enabled auto-merge (squash) March 23, 2026 16:16
auto-merge was automatically disabled March 26, 2026 10:39

Pull request was closed

@djukicmilica djukicmilica reopened this Mar 26, 2026
@djukicmilica djukicmilica merged commit 7aa36dd into microsoft:main Mar 26, 2026
83 of 85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 Finance GitHub request for Finance area From Fork Pull request is coming from a fork Linked Issue is linked to a Azure Boards work item

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: [Subscription Billing] Refactor Contract Line Page Loading Logic to Prevent corrupting Subscription Line

3 participants